[CMAKE] Revert build baseline to C++17#19805
Merged
MasterJH5574 merged 1 commit intoJun 17, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request downgrades the required C++ and CUDA standards from C++20 to C++17 in the CMake configuration files, and updates the installation documentation to reflect the lower minimum compiler version requirements. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tlopex
approved these changes
Jun 17, 2026
tqchen
approved these changes
Jun 17, 2026
Revert the CMake C++/CUDA standard from C++20 back to C++17, undoing the standard-setting portion of apache#19734 and restoring the v0.25.0.rc0 build baseline. The C++20 baseline broke the manylinux Linux wheels: under C++20, libstdc++'s constexpr std::string paths reference symbols newer than the manylinux_2_28 runtime baseline (e.g. _M_replace_cold @ GLIBCXX_3.4.30, GCC 12.1+), so the wheel fails to import with "undefined symbol". The compiler (GCC 14.2.1) is unchanged from rc0 -- only the standard differs -- so C++17 restores the working symbol set. Only the standard-setting surfaces are reverted (CMakeLists.txt, the LLVM compile probe, docs); the C++17-compatible source modernizations from apache#19734 are intentionally kept to avoid reintroducing deprecated constructs.
MasterJH5574
force-pushed
the
tvm-dev/2026-06-16-revert-c++20
branch
from
db192bb to
a28a872
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the CMake C++/CUDA standard from C++20 back to C++17, undoing the standard-setting portion of #19734 and restoring the v0.25.0.rc0 build baseline.
The C++20 baseline broke the manylinux Linux wheels: under C++20, libstdc++'s constexpr std::string paths reference symbols newer than the manylinux_2_28 runtime baseline (e.g. _M_replace_cold @ GLIBCXX_3.4.30, GCC 12.1+), so the wheel fails to import with "undefined symbol". The compiler (GCC 14.2.1) is unchanged from rc0 -- only the standard differs -- so C++17 restores the working symbol set.
Only the standard-setting surfaces are reverted (CMakeLists.txt, the LLVM compile probe, docs); the C++17-compatible source modernizations from #19734 are intentionally kept to avoid reintroducing deprecated constructs.